Lucas_Werkmeister_WMDE added a comment.

  Note that the general job / container (not sure which tbh) already installs 
packages:
  
    + exec docker run --volume 
/srv/jenkins/workspace/workspace/wikidata-query-gui-build/src:/src --volume 
/srv/jenkins/workspace/workspace/wikidata-query-gui-build/cache:/cache --volume 
/srv/jenkins/workspace/workspace/wikidata-query-gui-build/log:/log 
--security-opt seccomp=unconfined --init --rm --label 
jenkins.job=wikidata-query-gui-build --label jenkins.build=26 --env-file 
/dev/fd/63 docker-registry.wikimedia.org/releng/node12-test-browser:0.0.2 grunt 
create_build
    ++ /usr/bin/env
    ++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
    + cd /src
    + '[' '!' -f package.json ']'
    + node --version
    v12.21.0
    + npm --version
    7.5.2
    + '[' -e npm-shrinkwrap.json ']'
    + '[' -e package-lock.json ']'
    + npm ci
    
    added 1209 packages, and audited 1210 packages in 32s
    
    7 vulnerabilities (3 moderate, 4 high)
    
    To address issues that do not require attention, run:
      npm audit fix
    
    To address all issues (including breaking changes), run:
      npm audit fix --force
    
    Run `npm audit` for details.
    + npm run-script grunt create_build
    
    > [email protected] grunt
    > grunt "create_build"
    
    Running "auto_install:local" (auto_install) task
    running npm install --production --no-package-lock on /src...npm ERR! code 
ERESOLVE
    npm ERR! ERESOLVE unable to resolve dependency tree
    …
  
  So overall it looks like we’re trying to install dependencies twice, which 
probably isn’t very useful. I suggest we change the job configuration to run 
`only_build` instead of `create_build`, skipping the `auto_install`:
  
  name=Gruntfile.js
    grunt.registerTask( 'build', [
        'clean', 'create_build'
    ] );
    grunt.registerTask( 'create_build', [
        'auto_install', 'only_build'
    ] );
    grunt.registerTask( 'only_build', [
        'less', 'copy', 'useminPrepare', 'concat', 'cssmin', 'uglify', 
'filerev', 'usemin', 'htmlmin', 'merge-i18n'
    ] );

TASK DETAIL
  https://phabricator.wikimedia.org/T286479

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, MPhamWMF, maantietaja, CBogen, 
Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, Nandana, Namenlos314, 
Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, 
Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, 
Addshore, Mbch331, hashar
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to