Lucas_Werkmeister_WMDE added a comment.
This is kind of messed up: - Repo’s `changesDatabase` setting defaults to `false`. - We don’t configure it in mediawiki-config, so it’s `false` in production. - `dispatchChanges.php` takes that setting and creates a `JobQueueChangeNotificationSender` with it. - `JobQueueChangeNotificationSender` passes the value as the `'repo'` param into the `ChangeNotification` jobs it creates. - In `ChangeNotificationJob` – now in client! – the `'repo'` is therefore `false`, which would usually mean the local database. - However, as far as I can tell, the `'repo'` parameter isn’t actually used anywhere. Which is good, because by this point it would refer to the client wiki’s database, not the repo one! If it’s true that this `'repo'` job parameter isn’t used, we should just get rid of it completely. However, we need to be careful: repo and client might be on different train versions, so repo still needs to set the job parameter for at least one train after client stops requiring it. (Meanwhile, client’s own `changesDatabase` setting is never used at all.) TASK DETAIL https://phabricator.wikimedia.org/T285473 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
