zeljkofilipin added a comment.
In T277862#7208919 <https://phabricator.wikimedia.org/T277862#7208919>, @toan wrote: > Why are there so many browser tests in Lexeme, can't we just get rid of some of them(or at least mark them as skipped when running against beta and keep them if they serve a purpose in CI)? Having to many selenium tests is an anti-pattern. If anything could be tested with a different test (unit, api...) it should not be a selenium test. Having a subset of stable tests running daily and passing is better than having all tests running and failing. There are examples in core on how to do it. In package.json <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/package.json#11> update `selenium-daily` to only run tests marked `@daily`. Example: "selenium-daily": "npm run selenium-test -- --mochaOpts.grep @daily" If you want to include only some files, you can create a suite in wdio.conf.js <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/tests/selenium/wdio.conf.js#19>. Examples: "selenium-daily": "npm run selenium-test -- --suite daily --mochaOpts.grep @daily" suites: { daily: [ 'tests/selenium/wdio-mediawiki/specs/*.js', 'tests/selenium/specs/page.js', 'tests/selenium/specs/user.js' ] } I'm available for reviews or pairing. TASK DETAIL https://phabricator.wikimedia.org/T277862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, zeljkofilipin Cc: toan, Sahilgrewalhere, Lucas_Werkmeister_WMDE, zeljkofilipin, WMDE-leszek, Michael, Ladsgroup, Tarrow, hoo, Addshore, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
