Sarai-WMDE added a subscriber: Charlie_WMDE. Sarai-WMDE added a comment.
Hey, @Addshore. Thanks for the patch! I noticed that the change now made the "Get a shareable link" text smaller, which I guess is correct, since it's using tokens. I couldn't find design specifications to validate that the style is correct, tough (although the size in Figma is 16px), so I'll just give a heads-up to @Charlie_WMDE (who is on vacation) here, for her to check this when possible. I'd say this shouldn't block this task. I also noticed that the copy says "sharable" instead of "shareable"! I know that's not at all related to this ticket, but would you mind making a quick copy change there, Adam? Just so we don't have to create a separate task just for this. Would that be ok? F34564165: Screenshot 2021-07-26 at 17.04.36.png <https://phabricator.wikimedia.org/F34564165> TASK DETAIL https://phabricator.wikimedia.org/T285146 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Sarai-WMDE Cc: Charlie_WMDE, Addshore, Aklapper, Sarai-WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
