Krinkle added a comment.
I suggest reverting the changes that moved away from the (soft-deprecated) `WikiPage::prepareContentForEdit` method. This method is to my knowledge the only appropiate way we have for extension hooks during an edit stash or edit submit request to obtain the ParserOutput in a shared and cached way. The method was prematurely deprecated in T242249 <https://phabricator.wikimedia.org/T242249>. The recommended replacement involves boilerplate that's inappropiate for extension code (and nobody seems to have followed that recommendation). And what people actually did in some cases (call Content->getParserOutput) is problematic for performance. This method should only be called by code in charge of authorotativey parsing something for its own purpose, e.g. core when submitting an edit, or in rare cases where an extension perhaps constructs an unsaved Content object to render ad-hoc outside any revision or parsercache. In general that's not the case and such method should not be called. Then after the regression is fixed attention can focus on revisiting that unfinished deprecation (T242249 <https://phabricator.wikimedia.org/T242249>), and on detecting future regressions (T288707 <https://phabricator.wikimedia.org/T288707>). TASK DETAIL https://phabricator.wikimedia.org/T288639 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
