Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
As a Wikidata editor, I want property labels to be unique per language at all
times, so that different properties don’t get confused for one another (and so
that the `{{#statements:propertyName}}` parser function is unambiguous).
As a Wikibase developer, I want hard constraints
<https://doc.wikimedia.org/Wikibase/master/php/md_docs_topics_constraints.html>
to actually be enforced as strictly as they’re supposed to be.
**Problem:**
Currently, reverting an edit to a property label (or restoring a previous
revision with a different label) is allowed, even if another property got the
same label in the meantime, which means that after the revert/restore, two
properties have the same label. This is not supposed to be possible (if you try
to edit a property label so it’s the same as another property, you get an
error).
**Example:**
- Create `P1`, label it A
- Create `P2`, label it A2
- Relabel `P1` to A1
- Relabel `P2` to A
- Revert edit to `P1`
Both `P1` and `P2` will have the label `A`.
Note that the other main hard constraint, sitelink uniqueness, //is//
enforced on undo/restore:
F34617677: Screenshot 2021-08-23 at 11-41-55 Error.png
<https://phabricator.wikimedia.org/F34617677>
**BDD**
GIVEN a property with label //x// in a language
AND another property with label //y// in the same language
WHEN I try to set the first property’s label to //y//, whether as a regular
edit, as an undo, or as a restore
THEN the edit is rejected
**Acceptance criteria:**
- It’s not possible to have multiple properties with the same label in the
same language at the same time.
**Open questions:**
- Is it possible that this is intended behavior? (I haven’t looked at the
code for this yet, but at least I didn’t find any Phabricator tasks demanding
that the hard constraint should be relaxed on property reverts.)
TASK DETAIL
https://phabricator.wikimedia.org/T289473
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
