Lucas_Werkmeister_WMDE added a comment.
Yup, if the API returns the normalized value, the JS already updates
everything properly:
diff --git a/repo/includes/Api/SetClaim.php b/repo/includes/Api/SetClaim.php
index 2621fe33da..af8b984ff5 100644
--- a/repo/includes/Api/SetClaim.php
+++ b/repo/includes/Api/SetClaim.php
@@ -30,6 +30,7 @@
use Wikibase\Repo\Diff\ClaimDiffer;
use Wikibase\Repo\FederatedProperties\FederatedPropertiesException;
use Wikibase\Repo\SnakFactory;
+use Wikimedia\TestingAccessWrapper;
/**
* API module for creating or updating an entire Claim.
@@ -203,6 +204,7 @@ private function executeInternal(): void {
$index = $params['index'] ?? null;
$changeop = $this->statementChangeOpFactory->newSetStatementOp(
$statement, $index );
+ $statement = TestingAccessWrapper::newFromObject( $changeop
)->statement;
$this->modificationHelper->applyChangeOp( $changeop, $entity,
$summary );
$status = $this->entitySavingHelper->attemptSaveEntity(
$entity, $summary, $params, $this->getContext() );
But obviously we need a better fix for this than rudely reaching into the
change op’s private fields.
TASK DETAIL
https://phabricator.wikimedia.org/T289501
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz,
Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden,
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude,
Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
