Ladsgroup added a comment.
I looked at the patches, a brain dump: - One rather easy way to look at it, is to move the assets (logo, etc.) to the deploy repo (while keeping a default in the main one), it feels weird changing the gui codebase for something very specific to WMF (the gui is heavily used outside WMF as well). We should change it to support multiple sites but having the docroot for both wdqs and wcqs there seems misplaced to me. - speaking of docroot, Can I bikeshed? where does this name come from? it seems very unusual to me (by not conveying much information) but it might be just me not knowing about standard web servers. - I suggest splitting the puppet patch to 1- Refactor 2- adding wcqs. That way we can get the first part in and make sure nothing in wmde-side is broken - The traffic patch needs an LVS patch on top (maybe the third puppet patch?) - It might be me very conservative but maybe for start can we have the files in docroot hard-coded in puppet? There are not many of them and wildcard apache redirects seem scary to me but not a big deal. Just a suggestion. Feel free to ignore. HTH. Let me know if I can be of any service. Would be more than happy to help get this deployed. TASK DETAIL https://phabricator.wikimedia.org/T280247 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, Ladsgroup Cc: Manuel, Ladsgroup, Addshore, Aklapper, Gehel, CBogen, ttaylor, Zbyszko, Suran38, Biggs657, Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
