Silvan_WMDE added subscribers: guergana.tzatchkova, ItamarWMDE, Silvan_WMDE.
Silvan_WMDE added a comment.
Notes from task breakdown:
- create a web endpoint that receives mismatches and updates them in the
database (task to be created by @ItamarWMDE, no dependencies)
- payload is expected to be an array of full mismatch data, including the
updated `review_status`
- can't re-use the existing single-mismatch `MismatchPutRequest`
- create new batch validation rules (can't re-use the single-mismatch rules)
- respond with a redirect back to the results page (which will pick the new
results from the db and display them on the page)
- feature test the new route
- send mismatches from the internal `Results`page data model to that endpoint
on submit (task to be created by @guergana.tzatchkova, depends T289557
<https://phabricator.wikimedia.org/T289557>)
- create one form for each result (i.e. item), with the mismatches table
and a submit button
- submitting the form will trigger a handler to send the data
- the buttons will be disabled until the new endpoint task is done
- write a unit test for the `Results` page that mocks `$inertia` (see
`Home.vue`) and makes sure that the put method is called with the correct URL
and payload
- payload is expected to be an array of full mismatch data, including the
updated `review_status`
- tie together changed frontend data model with the endpoint (task to be
created by @Silvan_WMDE, depends on the two above)
- enable the submit buttons
- test e2e behaviour with browser tests: user can submitting a selected
value and the new state appears on the results page
- handle errors and display a Wikit message in the same way as done on the
Home page (see T289344 <https://phabricator.wikimedia.org/T289344>) (task to be
created by @guergana.tzatchkova, no dependencies)
- triggers on response statuses >=500 (handled in
`\App\Exception\Handler.php` already)
- modify the existing `redirect(route('home')` in `Handler.php` to
something more generic like `back()`
- Figma design
<https://www.figma.com/file/sgK1Go5my7ShZ1HQIxV2FI/Mismatch-Finder?node-id=1712%3A31755>
- maybe move the shared error message box including styles into its own vue
component (and replace in `Home.vue`)
- test e2e behaviour with browser tests
TASK DETAIL
https://phabricator.wikimedia.org/T290822
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Silvan_WMDE
Cc: Silvan_WMDE, ItamarWMDE, guergana.tzatchkova, Aklapper, Lydia_Pintscher,
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, Akuckartz, Nandana,
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper,
Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
