Lucas_Werkmeister_WMDE added a comment.
I’m not sure I understand the issue. As far as I can tell, there currently
aren’t any expressions left – all the values that reference other values
without just copying a single value look like value lists, not expressions:
$ grep '"value":.*{' tokens/dist/index.json | grep -v '"{[^}]*}"'
"value": "{box-shadow.inset.style.thin.value}
{color.accent.50.value}"
"value": "{box-shadow.inset.style.thin.value}
{color.utility.red.50.value}"
"value": "{box-shadow.inset.style.thin.value}
{color.utility.red.50.value}"
"value": "{box-shadow.inset.style.thin.value}
{color.utility.yellow.30.value}"
"value": "{box-shadow.inset.style.thick.value}
{color.base.100.value}"
"value": "{transition.property.color.value},
{transition.property.background-color.value},
{transition.property.border-color.value},
{transition.property.box-shadow.value}"
"value": "{transition.property.border-color.value},
{transition.property.box-shadow.value}"
"value": "{transition.property.color.value},
{transition.property.background-color.value}"
"value": "{transition.property.background-color.value},
{transition.property.border-color.value},
{transition.property.box-shadow.value}"
"value": "{box-shadow.inset.focus.progressive.value},
{box-shadow.inset.focus.inverted.value}"
"value": "{box-shadow.inset.focus.destructive.value},
{box-shadow.inset.focus.inverted.value}"
"value": "{box-shadow.inset.focus.progressive.value},
{box-shadow.inset.focus.inverted.value}"
"value": "{box-shadow.inset.focus.progressive.value},
{box-shadow.inset.focus.inverted.value}"
Figuring out how to evaluate expressions during compile time is what we
removed during story time, since it’s not needed at the moment. The current
situation (IIUC) is that there are no expressions within the token definitions,
therefore there are no expressions in the output token format either, and the
second AC will ensure that it stays this way for now. If we want to use
expressions again later, then we’ll have to figure out the compilation step,
but not at the moment.
TASK DETAIL
https://phabricator.wikimedia.org/T287389
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Tonina_Zhelyazkova_WMDE, Michael,
Aklapper, Jakob_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
