Volker_E added a comment.
In T266688#7271853 <https://phabricator.wikimedia.org/T266688#7271853>, @Sarai-WMDE wrote: >> There's a lot of gray area in here, though, especially step 2. I looked through some WVUI components I've built and found some examples of values for which I did not create a token: >> >> - `outline: 1px solid transparent` >> - `content: ' '` >> - `top: 50%` >> - `border: @border-width-base @border-style-base transparent` >> - `transition: background-color @transition-base, border-color @transition-base, border-width @transition-base;` >> >> Those could all be debatable. The goal would be to take the debate out of it as much as possible with clear instructions on when one should create a token. > > I'd say that, except for `content:' '`, all the listed properties could be defined using tokens or composite tokens, in case the creation of an alias is not justified. For the colors it's absolutely necessary to provide them as tokens, as themeability might be negatively impacted. For functionality like certain accessibility features, we might remain with a more static token implementation. Theming should and will be limited to a certain extent to not negatively impact users of the library. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
