Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, SDC General.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Currently, Wikibase only supports dispatching changes for entities that are
stored in the main slot of a page, more or less by accident.
name=RepoHooks::onRevisionFromEditComplete()
if ( $entityContentFactory->isEntityContentModel(
$wikiPage->getContent()->getModel() ) ) {
self::notifyEntityStoreWatcherOnUpdate(
$revisionRecord->getContent( SlotRecord::MAIN ),
$revisionRecord
);
$notifier = WikibaseRepo::getChangeNotifier();
// ...
(`WikiPage::getContent()` hard-codes the main slot.)
name=ChangeNotifier::notifyOnPageModified()
/** @var EntityContent $parentContent */
$parentContent = $parent->getContent( SlotRecord::MAIN );
'@phan-var EntityContent $parentContent';
$content = $current->getContent( SlotRecord::MAIN );
// ...
For changes to MediaInfo entities (stored in the `mediainfo` slot of file
pages), we never create any changes, the `wb_changes` table remains empty,
there is nothing to dispatch, pages using entity data (over 140 million,
according to `wbc_entity_usage`) aren’t updated. We probably want to fix this –
**however:** the impact of this on Commons (suddenly many more jobs in the job
queue) should be carefully considered, possibly with a staged rollout.
TASK DETAIL
https://phabricator.wikimedia.org/T293354
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, GFontenelle_WMF, maantietaja,
FRomeo_WMF, CBogen, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86,
E1presidente, Ramsey-WMF, Cparle, Anoop, SandraF_WMF, GoranSMilovanovic,
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen,
rosalieper, Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, Base,
matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond,
Steinsplitter, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
