Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Query UI, Gerrit. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Wikidata Query UI build #41 <https://integration.wikimedia.org/ci/job/wikidata-query-gui-build/41/console> failed: counterexample + git -C ./src/build commit -m 'Merging from 4d63180156443b59eba6cb477f8b424c16e66e2b' -m 'Bump bootstrap-table from 1.19.0 to 1.19.1 Bumps [bootstrap-table](https://github.com/wenzhixin/bootstrap-table) from 1.19.0 to 1.19.1. - [Release notes](https://github.com/wenzhixin/bootstrap-table/releases) - [Changelog](https://github.com/wenzhixin/bootstrap-table/blob/develop/CHANGELOG.md) - [Commits](https://github.com/wenzhixin/bootstrap-table/compare/1.19.0...1.19.1) --- updated-dependencies: - dependency-name: bootstrap-table dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Pull Request: https://github.com/wikimedia/wikidata-query-gui/pull/103' [production d5dffdd] Merging from 4d63180156443b59eba6cb477f8b424c16e66e2b 6 files changed, 4 insertions(+), 4 deletions(-) delete mode 100644 js/embed.vendor.min.5f1c7180a4d05a87929b.js create mode 100644 js/embed.vendor.min.7cb558e46015da96d5ee.js delete mode 100644 js/vendor.min.4d04d4141e5811e6ae01.js create mode 100644 js/vendor.min.8784f6fc265e46709859.js + git -C ./src/build push origin HEAD:refs/for/production%ready remote: remote: Processing changes: refs: 1 remote: Processing changes: refs: 1, done remote: ERROR: commit d5dffdd: Change-Id must be in message footer remote: remote: Hint: run remote: git commit --amend remote: and move 'Change-Id: Ixxx..' to the bottom on a separate line remote: To ssh://gerrit.wikimedia.org:29418/wikidata/query/gui-deploy ! [remote rejected] HEAD -> refs/for/production%ready (commit d5dffdd: Change-Id must be in message footer) error: failed to push some refs to 'ssh://[email protected]:29418/wikidata/query/gui-deploy' The problem is that Gerrit’s commit-msg hook gets confused where the Change-Id should go; if you get the `commit-msg` hook from Gerrit (like wikidata-query-gui-build does <https://gerrit.wikimedia.org/g/integration/config/+/489d6e714839fbe7099e52e31433654c86a44278/jjb/wikidata.yaml#121>) and create a commit with the same commit message from the output above, the final resulting commit message is: > Bump bootstrap-table from 1.19.0 to 1.19.1 > > Bumps bootstrap-table <https://github.com/wenzhixin/bootstrap-table> from 1.19.0 to 1.19.1. > > - Release notes <https://github.com/wenzhixin/bootstrap-table/releases> > - Changelog <https://github.com/wenzhixin/bootstrap-table/blob/develop/CHANGELOG.md> > - Commits <https://github.com/wenzhixin/bootstrap-table/compare/1.19.0...1.19.1> > > Change-Id: I031068cc15e3a171b1c80b0ae0c483b7f06d2b82 > > --- > > updated-dependencies: > > - dependency-name: bootstrap-table dependency-type: direct:production update-type: version-update:semver-patch > > ... > > Signed-off-by: dependabot[bot] <[email protected]> > Pull Request: https://github.com/wikimedia/wikidata-query-gui/pull/103 The Change-Id is in the middle of the message, and Gerrit doesn’t like that. TASK DETAIL https://phabricator.wikimedia.org/T295601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, MPhamWMF, maantietaja, CBogen, Akuckartz, Nandana, Namenlos314, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, xSavitar, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, jayvdb, Lydia_Pintscher, Paladox, Mbch331, Jay8g, Krenair, hashar, QChris
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
