Lucas_Werkmeister_WMDE added a subscriber: Catrope. Lucas_Werkmeister_WMDE added a comment.
> When we `require-from-url` the fixed file path, it doesn’t actually return anything: MediaWiki core works around this in `Resources.php`: // The file shipped by Vue does var Vue = ...;, but doesn't export it // Add module.exports = Vue; programmatically return file_get_contents( "$IP/$file" ) . ';module.exports=Vue;'; But we can’t easily do this in `test:mwlibs` without writing our own `require-from-sync`, I think. @Catrope would you consider adding this `module.exports=Vue;` assignment directly to the `vue.global(.prod).js` files shipped by MediaWiki? That would fix our problem here and also slightly simplify the ResourceLoader setup, at the cost of having to repeat this step each time we want to update the bundled Vue. TASK DETAIL https://phabricator.wikimedia.org/T297381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Catrope, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org