Lucas_Werkmeister_WMDE added subscribers: Tarrow, Jakob_WMDE. Lucas_Werkmeister_WMDE added a comment.
> And I think we’ll want to make sure that this div is in the part of the HTML that doesn’t end up in the parser cache. I discussed this a bit with @Tarrow and it might be trickier than expected. Apparently, the termbox HTML sometimes ends up in the parser cache (there is some PlaceholderExpander mechanism, but it’s not expected to be used all the time?), and there is also a `termboxVersion` option by which the parser cache may be split. @Jakob_WMDE would probably know more in this area. However, I don’t think we’ll have time to figure this out fully before the lexicographical data hike starts, so I think this might have to wait until March or so. Fortunately, this doesn’t need to block the Termbox Vue 3 rollout at all. For now, we can add a wrapper element in our own JS, just before calling `.mount()`; the only disadvantage of this is that the server-rendered HTML lacks this extra element, but that difference should be acceptable for a while. We can write the JS code in such a way that it detects the wrapper if it’s already there, and then add the wrapper on the PHP side later, when we figure out how best to do it. (If the JS can handle HTML with or without wrapper, that should also make the PHP side easier – we might not have to worry about the parser cache as much in that case.) So: for now, make the JS add the wrapper element inside which we mount the app; later, also make the PHP add this wrapper element to the HTML it generates. (I don’t think we want to add this HTML to the SSR-generated HTML, that should still start with `<section>`.) TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Jakob_WMDE, Tarrow, Catrope, Michael, Lucas_Werkmeister_WMDE, Aklapper, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
