Reedy created this task.
Reedy added projects: Wikidata-Page-Banner, Technical-Debt.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
The use of `WikidataPageBanner::$wpbFunctionsClass` as an abstraction layer
is not a helpful way of representing the code.
We don't have any type hints.
The comments suggest it's partially for testing purposes... There has to be a
better way of doing this
/**
* Singleton instance for helper class functions
* This variable holds the class name for helper functions and is used
to make calls to those
* functions
* Note that this variable is also used by tests to store a mock
classname of helper functions
* in it externally
* @var string
*/
public static $wpbFunctionsClass = "WikidataPageBannerFunctions";
``
TASK DETAIL
https://phabricator.wikimedia.org/T301093
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Aklapper, Reedy, darthmon_wmde, DannyS712, Izno, Wikidata-bugs,
Dinoguy1000, Lydia_Pintscher, Jay8g
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
