Lucas_Werkmeister_WMDE added a comment.
In T242959#7725445 <https://phabricator.wikimedia.org/T242959#7725445>, @Krinkle wrote: > There are a number of side-effect errors in production that suggest NameTableStore is not only failing to execute its query but also leaves the underlying connection in a dirty state and thus affecting unrelated other code paths: I guess that could be due to `NameTableStore::retryStore()` catching exceptions (including DB errors) without rethrowing them, which according to mw:Database transactions <https://www.mediawiki.org/wiki/Database_transactions> is “extremely bad practice” (and I remember @Ladsgroup removing several such cases in the past). But I might be missing something about the transaction handling in that class. TASK DETAIL https://phabricator.wikimedia.org/T242959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: cjming, Lucas_Werkmeister_WMDE, Jdforrester-WMF, Krinkle, hashar, Ladsgroup, Pablo-WMDE, Aklapper, Addshore, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
