ItamarWMDE added a comment.

  I'd assess this endeavor to be of medium effort. From what I can gather, 
there are a couple of places where we need to change the way diffs are 
rendered: Firstly, we might want to use or extend the WordLevelDiff 
<https://github.com/wikimedia/mediawiki/blob/1bb7b23610cbb140f364585fa36b3a54dcb779d0/includes/diff/WordLevelDiff.php>
 class from core's `Diff` namespace inside our own `data-model-services` 
sub-package's EntityDiff 
<https://github.com/wikimedia/Wikibase/blob/6307c5a3d9da963b34832ac62d0542854db4ef0e/lib/packages/wikibase/data-model-services/src/Diff/EntityDiff.php>
 and / or ItemDiff 
<https://github.com/wikimedia/Wikibase/blob/6307c5a3d9da963b34832ac62d0542854db4ef0e/lib/packages/wikibase/data-model-services/src/Diff/ItemDiff.php>
 classes. Then, we might want to update the way terms and claim diffs are 
rendered within BasicDiffView 
<https://github.com/wikimedia/Wikibase/blob/6307c5a3d9da963b34832ac62d0542854db4ef0e/repo/includes/Diff/BasicDiffView.php>
 and ItemDiffView 
<https://github.com/wikimedia/Wikibase/blob/6307c5a3d9da963b34832ac62d0542854db4ef0e/repo/includes/Diff/ItemDiffView.php>
 in the `Wikibase/Repo/Diff` namespace, to highlight only the changed words 
rather than the whole changed sentence.
  
  I'd still be happy to hear what @Addshore thinks of it, though, just as a 
sanity check.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to