AnneT added a comment.
Thanks, everyone, for your thoughtful comments, examples, and suggestions! I think we should move forward with keeping all menu items justified according to the interface direction, given the feedback here. We can always reevaluate if we get more feedback from RTL readers. In terms of mixed directionality, the screenshot @Michael posted is fairly close to what will happen if we wrap the label, match, and description in `<bdi>` tags. One minor difference is that, in the Wikidata example, the label's language is added as an attribute to an element that wraps both the label and the match, so there's no differentiation there. You can see this with the "Liebfrauenkirche" result. This label comes back with the language code `en` (presumably because this is the label's value in English and English is a fallback for Farsi while German is not), so the whole line is wrapped in an element with `lang="en"` and is therefore all readable left-to-right: F35040242: image.png <https://phabricator.wikimedia.org/F35040242> However, in this screenshot of the Codex TypeaheadSearch component, you can see that the label and match maintain the same order no matter what the languages are, so they arguably appear "backward" for this specific item: F35040209: Screen Shot 2022-04-05 at 4.00.55 PM.png <https://phabricator.wikimedia.org/F35040209> I suppose we could check to see if the language and match have the same lang code, and wrap them together if that's true. But you could also argue that the consistency of the current state is better. I've updated the patch associated with this task to include `<bdi>` tags around each piece of text within a Menuitem. Please let me know if you have further feedback, either here or in the patch! TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, R4356th, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, Hook696, darthmon_wmde, Kent7301, egardner, holger.knust, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, NatHillard, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Niedzielski, Wikidata-bugs, Jdlrobson, aude, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
