ItamarWMDE added subscribers: guergana.tzatchkova, ItamarWMDE, noarave,
Michael, Lucas_Werkmeister_WMDE.
ItamarWMDE added a comment.
**(Some background) possible language code scenarios**
- Valid language code → No spelling variant lookup, no warning message.
- Invalid language code (meaning the retrieved code is not in the list of
allowed codes) → Yes spelling variant lookup, yes warning message.
- No language code → Yes spelling variant lookup, no warning message.
- No language Item selected → No spelling variant lookup, no warning message.
- Loading language code request -> No spelling variant lookup, no warning
message, loading indicator shown (@Erdinc_Ciftci_WMDE Are there mocks for this
state? Should this be part of this task @Lydia_Pintscher?).
**Task Breakdown Notes**:
- We have the list of lang codes that are allowed as spelling variants.
- Field validation and error / warning message display is embedded in the
Wikit lookup component.
- If the language `P218` statement's value contains incorrect and valid data,
you will not receive a warning. If it is incorrect and invalid, a warning will
be shown.
- If the `P218` statement includes more than one value, the application will
use the first best ranked value (@Lydia_Pintscher does that chime correctly?).
**Potential Plan of Action**:
1. Either:
- Pass down the `wgLexemeLanguageCodePropertyId` to the
'new-lexeme-special-page' application via the config. [TASK TBW by
@guergana.tzatchkova] **Or in parallel:**
- Write a repository implementation (in the vue application's `data-access`
directory) to retrieve the language code property data from the API. [TASK TBW
by @noarave]
2. Add an action and event handler to call the API and retrieve the language
code from the repository. To see what happens when you select a language code,
scroll up to the first section of this comment. [TASK TBW by @Michael]
In parallel
- Extend the `wbgetclaims` action API module to support 'Best Ranked'
statements in addition to the currently available filters (@Lydia_Pintscher
does that sound a good investment for our users?) [TASK TBW by
@Lucas_Werkmeister_WMDE]
In parallel
- Add the i18n message to the `WikibaseLexeme` messages list in `en.json` and
`qqq.json`. and pass them down into the vue app via the ResourceLoader. [TASK
TBW by @ItamarWMDE]
TASK DETAIL
https://phabricator.wikimedia.org/T298142
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ItamarWMDE
Cc: Lucas_Werkmeister_WMDE, Michael, noarave, ItamarWMDE, guergana.tzatchkova,
Erdinc_Ciftci_WMDE, Bugreporter, Mahir256, Nikki, Aklapper, Lydia_Pintscher,
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi,
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper,
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
