Lucas_Werkmeister_WMDE added a comment.

  > Errors are shown post-submit in an error box above the Create Lexeme button 
like on the JS version. All errors are shown in the same way and we don't have 
individual field errors.
  
  Here’s what we currently get, more or less out of the box:
  F35073446: Screenshot 2022-04-29 at 16-32-43 Create a new Lexeme 
(experimental) - wiki1.png <https://phabricator.wikimedia.org/F35073446>
  
  This order is encoded in `HTMLForm::getHTML()`:
  
                $html = ''
                        . $this->getErrorsOrWarnings( $submitResult, 'error' )
                        . $this->getErrorsOrWarnings( $submitResult, 'warning' )
                        . $this->getHeaderText()
                        . $this->getBody()
                        . $this->getHiddenFields()
                        . $this->getButtons()
                        . $this->getFooterText();
  
  Changing it is going to be fairly painful, I think… the best way is probably 
to override `getHTML()` (it is `@stable to override`), but I’m worried that we 
might miss out on future changes made to that method (e.g. if another “segment” 
gets added to this `$html`).

TASK DETAIL
  https://phabricator.wikimedia.org/T298160

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, karapayneWMDE, Erdinc_Ciftci_WMDE, Aklapper, 
Lydia_Pintscher, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to