Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Lexicographical data,
wdwb-tech.
TASK DESCRIPTION
The WikibaseLexeme extension has two settings, `$wgLexemeNamespace` and
`$wgLexemeTalkNamespace`, which together define the namespace used to store
Lexemes. However, MediaWiki assumes that the talk namespace is always the
subject namespace + 1; for example:
name=NamespaceInfo::getTalk()
return $this->isTalk( $index )
? $index
: $index + 1;
I don’t know what happens when you set `$wgLexemeTalkNamespace` to something
other than `$wgLexemeNamespace + 1`, but I assume no good will come out of it.
To me this seems like a footgun that exists for no good reason, and I propose
we remove it and hard-code the talk namespace to be `$wgLexemeNamespace + 1`.
Historically, this code was apparently based on WikibaseMediaInfo, which at
the time also had `MediaInfoNamespace` and `MediaInfoTalkNamespace` settings,
originally introduced in Automatically register namespaces for MediaInfo
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/293124>.
`MediaInfoTalkNamespace` was removed in Use extension registration for
namespaces
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/337349>,
but reintroduced as `MediaInfoNamespaceTalk` in Register MediaInfo talk
namespace
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/351272>
(though it’s not clear to me whether the `MediaInfoNamespaceTalk` //config//
had any effect here, since I don’t see any code connecting it to the registered
`NS_MEDIAINFO_TALK` namespace), before both `MediaInfoNamespace` and
`MediaInfoNamespaceTalk` were finally removed in Make MediaInfo work with MCR
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/462743>.
TASK DETAIL
https://phabricator.wikimedia.org/T308549
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot,
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic,
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS,
Wikidata-bugs, aude, Addshore, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
