Lucas_Werkmeister_WMDE added a comment.
In T307869#7973088 <https://phabricator.wikimedia.org/T307869#7973088>, @dcausse wrote: > The patches above add few placeholder to allow tuning a custom profile meant to be use by the language selector on Special:NewLexeme: Thanks! I would suggest to keep Special:NewLexeme out of the context name and options as much as possible, and only call it something like “language” or “language selector”. My understanding is that, in theory, we would want to use the same profile when editing the language of an existing lexeme (though I don’t know if implementing that is on any roadmap at the moment). > The open question is how to pass a new URI param added to `wbsearchentities` meant to switch between profiles back to `EntitySearchElastic`. I would add it to the `EntitySearchHelper::getRankedSearchResults()` parameters (probably at the end, so it’s easier to do without breaking compatibility); non-CirrusSearch implementations of that interface would just ignore it. TASK DETAIL https://phabricator.wikimedia.org/T307869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Gryllida, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
