Lucas_Werkmeister_WMDE added a comment.
In T310255#7991620 <https://phabricator.wikimedia.org/T310255#7991620>, @gerritbot wrote: > Change 804283 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): > > [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to integration tests > > https://gerrit.wikimedia.org/r/804283 Ugh, this doesn’t work yet because there’s one more warning (and those also make gate-and-submit fail): PHPUnit\Framework\WarningTestCase ⚠ Warning │ │ The data provider specified for ApiStructureTest::testParameters is invalid. │ Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'centralauth' (localhost:/workspace/db/quibble-mysql-wc4x6073/socket) │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465 │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958 │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931 │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65 │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:270 │ /workspace/src/extensions/CentralAuth/includes/GlobalGroup/GlobalGroupLookup.php:56 │ /workspace/src/extensions/CentralAuth/includes/Api/ApiQueryGlobalAllUsers.php:273 │ /workspace/src/includes/api/ApiBase.php:1782 │ /workspace/src/tests/phpunit/structure/ApiStructureTest.php:175 │ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97 This is a unit test in core… should it also be an integration test? It tests that the parameter definitions of API modules are valid, and in CentralAuth that requires accessing the database so that the defined groups can be used for the `group` and `excludegroup` params. (Presumably, other APIs do something similar for `tags` parameters, that just doesn’t produce an error because the `change_tag_def` table would exist in the real wiki.) TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, Mbch331, Jay8g, hashar
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
