Lucas_Werkmeister_WMDE added a comment.
In T235901#7465832 <https://phabricator.wikimedia.org/T235901#7465832>, @Lucas_Werkmeister_WMDE wrote: >> The `senses` and `forms` of a returned lexeme entity aren’t entities themselves, they’re ordinary tables. Only the custom `getForms()` and `getSenses()` methods take care of properly creating entities. > > I think we can leave this open for feedback after the initial Beta rollout. Should `getForms()` and `getSenses()` exist at all? Or should `.forms` and `.senses` contain entity objects already? And in either case, should they be indexed numerically (1, 2, …) or by ID (`L1-F1`, `L1-F2`, … – or just `F1`, `F2`, …?)? Maybe the initial testers have some feedback on this. I think we can leave `.forms` and `.senses` as they are at the moment – not documented as part of the stable interface, but not particularly hidden either. Similar to the `.claims` on all entities (I suppose they’re `.statements` on MediaInfo?), where we expect users to use `:getAllStatements()` and other functions instead. TASK DETAIL https://phabricator.wikimedia.org/T235901 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Jdforrester-WMF, DVrandecic, So9q, daniel, Nikki, Infovarius, Premeditated, Alicia_Fagerving_WMSE, Marsupium, Lucas_Werkmeister_WMDE, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, RhinosF1, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, jberkel, Psychoslave, Wikidata-bugs, aude, Shizhao, Nemo_bis, Darkdadaah, Mbch331, Ltrlg, Krenair
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
