Lucas_Werkmeister_WMDE added a comment.
> Make sure to consider whether the core class WordLevelDiff is marked as "newable", meaning that we are able to instantiate it outside of core WordLevelDiff was last substantially changed in 2016, so it predates the stable interface policy (created beginning of 2017). To me it seems plausible that marking it newable was simply not done yet, but there wouldn’t be any reasons not to do it either. (Alternatively, `TableDiffFormatter` is already newable and uses `WordLevelDiff`; we might be able to use `TableDiffFormatter`.) TASK DETAIL https://phabricator.wikimedia.org/T303317 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
