Lucas_Werkmeister_WMDE added a comment.
Okay, I found another broken merge. Museo diocesano di Capua <https://www.wikidata.org/w/index.php?title=Q21196221&diff=1671017251&oldid=1559840158> gained an Italian alias through a merge, but in the entityterms API <https://www.wikidata.org/w/api.php?action=query&format=json&prop=entityterms&titles=Q21196221&formatversion=2&wbetlanguage=it> (and in the term store) it’s missing. However, in logstash <https://logstash.wikimedia.org/goto/b7e836966d8583728a0d542ab28eaae5>, there are only two `WikibaseTerms` events for this ID: - 09:58:28.607 UTC: schedule `saveTermsOfEntity` for Q21196221 - 09:58:28.813 UTC: run `saveTermsOfEntity` for Q21196221 In the full log events for this request ID <https://logstash.wikimedia.org/goto/679396f7a210051aa4fe8ed4adbf12d8>, we see a few more events: - Transaction spent 9ms in writes, under the 3s limit - schedule `saveTermsOfEntity` for Q55386461 - run `saveTermsOfEntity` for Q55386461 - schedule `saveTermsOfEntity` for Q21196221 - Possibly redundant parse - run `saveTermsOfEntity` for Q21196221 - schedule `deleteTermsOfEntity` for Q55386461 - Possibly redundant parse - Possibly redundant parse (In this order – i.e. the Q55386461 `saveTermsOfEntity` //runs// before the Q21196221 one is scheduled!) There is no trace of an error here. So I think we’re looking at two (or more) separate issues here: as mentioned in T309445#8039853 <https://phabricator.wikimedia.org/T309445#8039853>, sometimes writing the terms fails due to a database error, and it’s a bug that we don’t retry it; but also, unrelatedly, sometimes the terms don’t end up in the term store even though `ItemTermStoreWriterAdapter::saveTermsOfEntity` does //not// detect any error. I wonder if this is due to the fact that we’re making several edits (remove data from old item, add data to new item, redirect old item to new item) in one API request? At least, I assume that explains why we’re seeing some secondary data updates run before others are scheduled, and I could imagine that this causes some confusion. TASK DETAIL https://phabricator.wikimedia.org/T309445 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
