Sarai-WMDE added a comment.
Just a couple of comments after reviewing the design touch ups in Beta <https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha>: 1. Regarding... > All elements within the infopanel should have a vertical spacing of 16px (1rem) between them Unfortunately, the space around the lemma card is still 1em (14px) instead of 1rem (16px). This should be corrected. F35485138: Screenshot 2022-08-23 at 10.11.36.png <https://phabricator.wikimedia.org/F35485138> 2. The new 1rem margin is being applied to the elements within the lemma card via the selector `.wbl-snl-infopanel__content :first-child`. This is causing the card to display incorrect spacing. The extra internal margin should be removed. F35485159: Screenshot 2022-08-23 at 10.26.42.png <https://phabricator.wikimedia.org/F35485159> 3. The margin around the warning message should also be corrected. It's currently 0.5em (7px) while it, again, should be 1rem. Looks like that would be the default spacing if a different margin wouldn't be imposed to the component. (The message wasn't there when I initially checked the NewLexemeAlpha page, so let me know if I should create a separate ticket.) F35485146: Screenshot 2022-08-23 at 10.18.11.png <https://phabricator.wikimedia.org/F35485146> All the rest looks awesome!! Thanks @noarave and @guergana.tzatchkova. TASK DETAIL https://phabricator.wikimedia.org/T312652 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: guergana.tzatchkova, Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
