Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, ci-test-error, Wikidata Dev Team. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: wdwb-tech.
TASK DESCRIPTION DM: Add type hints to Statement <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/828519> added the return type `?string` to `Statement::getGuid()`, which breaks Phan in WikibaseQualityConstraints (build <https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/201179/console>): counterexample src/ConstraintCheck/Context/MainSnakContext.php:170 PhanTypeMismatchArgumentNullable Argument 3 ($statementGuid) is $this->statement->getGuid() of type ?string but \WikibaseQuality\ConstraintReport\ConstraintCheck\Context\MainSnakContextCursor::__construct() takes string defined at src/ConstraintCheck/Context/MainSnakContextCursor.php:36 (expected type to be non-nullable) src/ConstraintCheck/Context/QualifierContext.php:43 PhanTypeMismatchArgumentNullable Argument 3 ($statementGuid) is $this->statement->getGuid() of type ?string but \WikibaseQuality\ConstraintReport\ConstraintCheck\Context\QualifierContextCursor::__construct() takes string defined at src/ConstraintCheck/Context/QualifierContextCursor.php:42 (expected type to be non-nullable) src/ConstraintCheck/Context/ReferenceContext.php:51 PhanTypeMismatchArgumentNullable Argument 3 ($statementGuid) is $this->statement->getGuid() of type ?string but \WikibaseQuality\ConstraintReport\ConstraintCheck\Context\ReferenceContextCursor::__construct() takes string defined at src/ConstraintCheck/Context/ReferenceContextCursor.php:48 (expected type to be non-nullable) src/ConstraintCheck/Helper/SparqlHelper.php:370 PhanTypeMismatchArgumentNullableInternal Argument 3 ($subject) is $statement->getGuid() of type ?string but \str_replace() takes array|string (expected type to be non-nullable) src/Job/UpdateConstraintsTableJob.php:156 PhanTypeMismatchArgumentNullable Argument 1 ($constraintId) is $constraintId of type ?string but \WikibaseQuality\ConstraintReport\Constraint::__construct() takes string defined at src/Constraint.php:40 (expected type to be non-nullable) We need to find a solution to this to unblock CI for WikibaseQualityConstraints TASK DETAIL https://phabricator.wikimedia.org/T317101 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
