AnneT added a comment.

  We could potentially fix this by updating the `onSubmit()` handler in 
CdxTypeaheadSearch to check if there is a currently highlighted item and, if 
so, do the following:
  
  - `preventDefault()` on the submit event
  - run the `onSearchResultClick()` method to emit the proper data for 
instrumentation
  - navigate to the highlighted item's URL
  - return
  
  We might even be able to bypass all of this via some key modifiers on the 
menu item links in the template, but I haven't looked into that yet.
  
  Would this be acceptable from the Web team's standpoint, given that the form 
would no longer be submitted under this circumstance, and a different event 
would be emitted (`search-result-click` instead of `submit`)?

TASK DETAIL
  https://phabricator.wikimedia.org/T317682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT
Cc: dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, 
Lucas_Werkmeister_WMDE, phuedx, hnijhuis, VirginiaPoundstone, NHillard-WMF, 
Astuthiodit_1, STH, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, 
Universal_Omega, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 
Demian, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, Xover, GoranSMilovanovic, 
QZanden, EBjune, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to