hashar added a comment.
Some more discussion happened on the revert change https://gerrit.wikimedia.org/r/c/mediawiki/core/+/841159 @Mabualruz about your change https://gerrit.wikimedia.org/r/c/mediawiki/core/+/838733 , it did pass on October 6th at 7:40 UTC. But that result is almost instantly obsolete since we trigger jobs which clone multiple repositories. Thus as code is being merged in eg ContentTranslation, another run of CI would lead to different results which is what happened in this case. When a code causes a test to fail, every repositories relying on this cause ends up broken. In this case it affected a Selenium job which is shared by roughly 60 repositories (list at T320471#8306725 <https://phabricator.wikimedia.org/T320471#8306725>). Which mean no changes made to this repositories can be merged which is thus blocking a lot of people. The policy we have is to revert immediately to unbreak CI given code can always be proposed again. In this case it additionally blocked the MediaWiki train :) Most probably one could have reached out directly to you to have some synchronization and maybe a hot fix would have been easy to do. Then in most case who ever are presents at the time on IRC would take the easy path: revert and resolve the issue immediately then investigate for a proper patch later on. The aim is really to unblock everyone. Also Gerrit should not let us submit changes manually, that is T226123: Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit <https://phabricator.wikimedia.org/T226123> which would probably remove the Submit permission entirely. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh, hashar Cc: santhosh, abi_, Zabe, Mabualruz, Lucas_Werkmeister_WMDE, hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, taavi, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
