ItamarWMDE added a comment.
In T288511#8285994 <https://phabricator.wikimedia.org/T288511#8285994>, @Lucas_Werkmeister_WMDE wrote: > We also think this needs to go through story writing. What happens with the calendar model and precision? In what way are dates currently stored, and how are we changing that? What does the result look like for users? > > Currently, we don’t have enough information to estimate this task. I'll try and answer the questions as I understand them. - "What Happens with the calendar model and precision?" Can you elaborate on that? I'm not sure what expectation or context you are considering here? - "In what way are dates currently stored, and how are we changing that?" Currently, dates (as all wikidata values) are stored as a string (as they can be arbitrarily any type wikidata supports). See 2021_07_19_123858_create_mismatches_table.php <https://github.com/wmde/wikidata-mismatch-finder/blob/73a3478e0b50ef30944145002329a926c3724338/database/migrations/2021_07_19_123858_create_mismatches_table.php#L17-L34>. What this change most probably will require us to do, is to add another column to this table to be able to store arbitrary meta information about a value (in this case, it will be calendar model, in the geocoordinates case, it will be globe). Additionally, we will have to adapt the csv import validator <https://github.com/wmde/wikidata-mismatch-finder/blob/73a3478e0b50ef30944145002329a926c3724338/app/Jobs/ValidateCSV.php#L95-L149> to allow for this extra field in the CSV, as described in the task. - "What does the result look like for users?" I would assume the result for each Wikidata Value will look like the user inputted it, as specified in the list at the description of this task, there's no manipulation on the display of dates done on our part, only validation. However, this question is important, and probably needs some UI work with regard to properly visualizing the calendar model. I think @Lydia_Pintscher and I discussed this in the past. TASK DETAIL https://phabricator.wikimedia.org/T288511 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: ItamarWMDE, Lucas_Werkmeister_WMDE, Hjfocs, Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
