Lucas_Werkmeister_WMDE added a comment.
In T317682#8285551 <https://phabricator.wikimedia.org/T317682#8285551>, @phuedx wrote: > In T317682#8285303 <https://phabricator.wikimedia.org/T317682#8285303>, @Jdlrobson wrote: > >>> Are we also changing MediaWiki searchSuggest behavior (“legacy search”) to do the same thing? >> >> I don't know who would be the right person to ask. I think legacy Vector is becoming less important as we roll out desktop improvements. I don't think the web team particularly cares. Suggest not changing it until someone asks and maybe pinging a few product analytics folks (maybe in the shared Slack channel?) ? > > Definitely reach out to Product Analytics and the Search Platform teams. @phuedx can you maybe reach out to those teams (and maybe also ask about decommissioning)? I don’t think I’m in the right Slack channels for that. In T317682#8254889 <https://phabricator.wikimedia.org/T317682#8254889>, @phuedx wrote: > In T317682#8251384 <https://phabricator.wikimedia.org/T317682#8251384>, @Jdlrobson wrote: > >> Regarding the instrumentation, tracking these as a submit event instead of a click also seems a bug, so that sounds fine to me. > > Seconded! However, it is consistent with the instrumentation for the non-Vue search treatment … This behaviour will need to be corrected in both instruments so that the corresponding datasets are still comparable. If I’m not mistaken, the “old search” side of this tracking happens in this code <https://gerrit.wikimedia.org/g/mediawiki/extensions/WikimediaEvents/+/3a4b406e0bfbb2d77288f785cc21e1b4a5360d7b/modules/ext.wikimediaEvents/searchSatisfaction.js#602> – that looks like we could change it to log either “click” or “submit” depending on the `data.action`, without actually changing the behavior (to reduce the amount of required changes). Does that sound okay? TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: EBernhardson, ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, Lucas_Werkmeister_WMDE, phuedx, hnijhuis, Jersione, Hellket777, NHillard-WMF, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
