Lucas_Werkmeister_WMDE added a comment.
Correction: there might be more `Serializable`-related warnings, because the above job failed before it ran the DB tests. (But it at least finished running the non-DB tests and reported all the errors in there, instead of crashing partway through as it used to.) `git grep 'createMock.*EntityId:'` finds 16 occurrences. I think a convenient way to make all of them work would be to add `__serialize()` / `__unserialize()` methods to the `EntityId` interface, so that PHPUnit will mock them automatically. (This would be a breaking change, but the data model `RELEASE-NOTES.md` already list the in-progress version as a major version update (10.0.0) with breaking changes.) I wonder if this would be acceptable? TASK DETAIL https://phabricator.wikimedia.org/T301249 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Lucas_Werkmeister_WMDE Cc: Michael, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Nikerabbit, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
