Lucas_Werkmeister_WMDE added a comment.
> - This could be achieved using a soft (see T289474 <https://phabricator.wikimedia.org/T289474>) constraint (hardcoded, similar to T212869 <https://phabricator.wikimedia.org/T212869>). At the time, T212869 <https://phabricator.wikimedia.org/T212869> was implemented in `TermValidatorFactory::getFingerprintValidator()`, but the code seems to have moved around a bit since then; the `FingerprintUniquenessValidator` is now calld in `ChangeOpFingerprintResult::validate()`, while the `LabelDescriptionNotEqualValidator` is used in `ChangeOpLabel::validate()` and `ChangeOpDescription::validate()`. The new validator for “no mul description” can probably go into `ChangeOpDescription`. We also need to check whether, as in T212869 <https://phabricator.wikimedia.org/T212869>, we need to implement this check separately for `Special:NewProperty` (and `Special:NewItem`?) as well, or if the special pages are covered by the `ChangeOp` validation. (This might have been fixed for `Special:NewProperty` with validate term length in Special:NewProperty <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/808989> for T308659 <https://phabricator.wikimedia.org/T308659>.) Other places to check, just to make sure that the validator is being called: - wbeditentity - wbsetdescription - Special:SetDescription - Special:SetLabelDescriptionAliases TASK DETAIL https://phabricator.wikimedia.org/T313027 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Manuel, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
