Michael added a comment.
In T322683#8389816 <https://phabricator.wikimedia.org/T322683#8389816>, @Sarai-WMDE wrote: >> it is tiny > > Absolutely agreed. My suggestion: let's use a 12px* non-focusable icon <https://www.accessibility-developer-guide.com/examples/forms/required/#better-approach-using-an-icon> instead of plain text. *This size might be too big indeed, so let's keep our minds open for a smaller, potentially 8px icon. This approach might also require altering the Label mixin in WiKit: to be validated with engineers. Mh, the reasoning given in that blog-post for using an icon instead of an asterisk is that the `aria-hidden` is not respected in focus mode. Sadly, it doesn't specify what screen reader or "focus mode" that refers to. But that article is from 2018, we should verify if this bug indeed still exists in 2022, over 4 years later. //If// we want to use an icon instead, we should probably implement it only after we decided whether we want to go for the Codex Lookup. >> it has a large gap before it > > Agreed again. The spacing between the label and the required icon should be reduced by half (to 0.25em). This space comes from Wikit and was probably designed for the tooltip-icon in Query Builder <https://query.wikidata.org/querybuilder/?>. We can override that Wikit style in a somewhat hacky and brittle way like this: .wbl-snl-lemma-input.wikit .wikit-TextInput__label-wrapper { gap: 0.25em; /* we could also use a token here */ } But it would probably also make sense to have clarity on whether we want to switch to the Codex Lookup for this. >> it has no tooltip > > This is a very commonly extended pattern, so I'm unsure that a tooltip would be essential to ensure understanding. Nevertheless, I've found some recommendations that encourage this practice for extra clarification. The browser default on hover will do. That's a simple change, we just need the copy. TASK DETAIL https://phabricator.wikimedia.org/T322683 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
