Sarai-WMDE added a comment.
In T323734#8420048 <https://phabricator.wikimedia.org/T323734#8420048>, @Lucas_Werkmeister_WMDE wrote: > Note that the patch also reduces the visual size of the main / English logo at 100% zoom (left is old / without the patch, right is new / with the patch): > F35817572: image.png <https://phabricator.wikimedia.org/F35817572> > The PNG file now has the same width as most other project logos, 135px; I can’t say whether the visual change is good or not. (At 150% and 200%, there’s no difference; I don’t know whether the -1.5x and -2x files were inconsistent with the main file before or are inconsistent now.) I’ll still deploy this change, but it might need a follow-up. All logos have the same sizing properties applied to them now, and are almost identical in size. What appears to be causing the visual difference between them is the extra horizontal white space that exists around the Wikidata logo in the png file. That difference in the horizontal margins is making Wikidata's logo appear optically smaller in context (the same is happening with the Commons logo, for example): | F35818842: enwiki-2x.png <https://phabricator.wikimedia.org/F35818842> | | F35818843: wikidatawiki-2x.png <https://phabricator.wikimedia.org/F35818843> | F35818868: commonswiki-2x.png <https://phabricator.wikimedia.org/F35818868> | | The resizing made this more obvious, and now it's easy to perceive how Wikidata's logo is not aligned with the menu's content (as Wikipedia's is). There are a couple of solutions if we want to make the logo look aligned with the menu's content again: 1. Increase the `background-size` applied to the Wikidata logo to compensate for the extra white space: I find 146px is a soft spot (although this would introduce an inconsistency in a code that now's nicely aligned), or 2. Create a new logo file with reduced margin. I would also understand it if we left this as is: the optical misalignment is not inconsistent, it's not causing any layout nor UX issues. It's also only affecting the 'old'/Vector legacy look. Thoughts? TASK DETAIL https://phabricator.wikimedia.org/T323734 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Stang, Sarai-WMDE Cc: Sarai-WMDE, Lucas_Werkmeister_WMDE, Aftabuzzaman, Aklapper, Stang, LisafBia6531, Astuthiodit_1, Yodas_henchman, NguoiDungKhongDinhDanh, karapayneWMDE, Invadibot, Zabe, maantietaja, Juan90264, ItamarWMDE, Akuckartz, CptViraj, AKA_MBG, Dibya, 94rain, Nandana, Tks4Fish, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, JEumerus, Scott_WUaS, Ananthsubray, Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Wikidata-bugs, Snowolf, Base, aude, Dcljr, Isarra, Matanya, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
