Lucas_Werkmeister_WMDE added a comment.
In T321770#8399946 <https://phabricator.wikimedia.org/T321770#8399946>, @Lucas_Werkmeister_WMDE wrote: > @Ladsgroup and @daniel – I just stumbled across this paragraph in the `LBFactory::autoReconfigure()` (and `reconfigure()`) phpdoc: > >> @warning This must only be called in top level code such as the execute() >> method of a maintenance script. Any database connection in use when this >> method is called will become defunct. > > This no longer applies, right? `DBConnRef`s automatically reconnect, and we don’t really use non-ref connections anymore? Uploaded a Gerrit change to remove that comment <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/860923>. TASK DETAIL https://phabricator.wikimedia.org/T321770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel, Michael, Lucas_Werkmeister_WMDE, hoo, Aklapper, Ladsgroup, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
