Lucas_Werkmeister_WMDE added a comment.

  > Regarding the tablet breakpoint: I'm not able to find any mention of the 
spacing change in the header specs 🤔  The header seems to stay the same, or at 
least that's what's documented in the original MVP designs 
<https://www.figma.com/file/sgK1Go5my7ShZ1HQIxV2FI/Mismatch-Finder?node-id=1119%3A22624&t=vJ5Quj7iKRUiFnkY-0>
 and the SPA consolidation specs 
<https://www.figma.com/file/2Sarzaww3tZQiLrVOXj7iE/SPA-consolidation?node-id=304%3A4351&t=F3AoLxAKJHlSjGmo-0>
 (which now need to be updated to reflect the right spacing). I'm not sure why 
this distinction was made, but it could be related to trying to fix some layout 
issues (see #100 
<https://github.com/wmde/wikidata-mismatch-finder/pull/100/files>)?
  
  It looks like the different header margin was added in #82 
<https://github.com/wmde/wikidata-mismatch-finder/pull/82> (specifically this 
commit 
<https://github.com/wmde/wikidata-mismatch-finder/pull/82/commits/dbb929f3f486d1c58d6d73c8c5daacbd47cd94c1>),
 part of porting to Wikit <https://phabricator.wikimedia.org/T289057>; I don’t 
see why, though. Let’s always use `small` then, I guess.

TASK DETAIL
  https://phabricator.wikimedia.org/T323678

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, 
Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to