Sarai-WMDE added a comment.
All looking great. ACs were all met and the ticket can be closed. > Before I close the ticket, I just wanted to double-check the inconsistencies that you mentioned in the ticket. > You have the link spacing on the Query Builder as 2.5rem here and for Mismatch Finder as 2rem on this ticket: T324366 <https://phabricator.wikimedia.org/T324366> The 2.5rem spacing mentioned in this ticket refers to the bottom margin of the main container, that separates the content of the page from the footer. This value should be the same in all SPAs (that's currently the case with Query builder and Mismatch finder). The 2rem value in T324366 <https://phabricator.wikimedia.org/T324366> refers to the spacing between the link groups within the footer, which is also consistent between both tools. In conclusion, all good. TASK DETAIL https://phabricator.wikimedia.org/T324356 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Sarai-WMDE Cc: Arian_Bozorg, Aklapper, Sarai-WMDE, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
