cscott created this task. cscott added a project: Wikidata-Page-Banner. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION See T93106: GSoC proposal for Wikivoyage PageBanner extension <https://phabricator.wikimedia.org/T93106> for background on WikidataPageBanner. In 439656e01974e3cbc57902fb4ef33e71c1a386d5 <https://phabricator.wikimedia.org/rMW439656e01974e3cbc57902fb4ef33e71c1a386d5> (T293513 <https://phabricator.wikimedia.org/T293513>) we moved TOC generation to ParserOutput::getText(). The WikidataPageBanner extension relies on being able to get the TOC HTML "by the back door" in the OutputPageParserOutput hook code here <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikidataPageBanner/+/8cb6f38ae0b633103b5c4db09e8069d01e11476b/includes/WikidataPageBanner.php#234>, modifying it to remove the `class` and `id` attributes, inserting it into the output of its parser function code here <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikidataPageBanner/+/8cb6f38ae0b633103b5c4db09e8069d01e11476b/templates/banner.mustache#21> and then suppressing the "actual" TOC by setting `injectTOC` to false code here <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikidataPageBanner/+/8cb6f38ae0b633103b5c4db09e8069d01e11476b/includes/WikidataPageBanner.php#218>. Now that the TOC HTML is being generated in ParserOutput::getText(), there is nothing for WikidataPageBanner to insert. TASK DETAIL https://phabricator.wikimedia.org/T328087 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: cscott Cc: Aklapper, ssastry, cscott, Wikidata-bugs, Lydia_Pintscher
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
