Pginer-WMF reopened this task as "Open". Pginer-WMF added a comment.
As mentioned in previous comments (T310259#8588960 <https://phabricator.wikimedia.org/T310259#8588960> and T310259#8589199 <https://phabricator.wikimedia.org/T310259#8589199>) there is part of the integration that seems to still be missing. As a result, the "edit language links" option, unlike other options such as "Translate" is not displayed for pages not available in other languages (example <https://en.wikipedia.org/wiki/Brush_cart> ): F36823425: en.wikipedia.org_wiki_Brush_cart(iPad Air).png <https://phabricator.wikimedia.org/F36823425> Nik provided some technical details about this in previous comments: In T310259#8589199 <https://phabricator.wikimedia.org/T310259#8589199>, @ngkountas wrote: > Adding to Pau's comment above, I checked that the module that registers the “Edit language links” action button is the `wikibase.client.vector-2022` module. I checked the loaded modules for the above page <https://en.wikipedia.org/wiki/Anniversary_Peak> (using `mw.inspect()` inside the Developer’s console) and the module doesn’t seem loaded. This is why the button is not visible. I checked the conditions used to add the module, in the codebase <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/client/includes/Hooks/BeforePageDisplayHandler.php#83> and I believe it's the following condition that prevents the module from being added: > > $outputPage->getProperty( 'wikibase_item' ) !== null > > The `wikibase_item` property for this page seems to be undefined. We can easily verify that by using the following API URL: https://en.wikipedia.org/w/api.php?action=query&prop=pageprops&titles=Anniversary_Peak&format=json and check that there is no "wikibase_item" key returned. > > So, I think we should also add the `wikibase.client.vector-2022` module for pages where `wikibase_item` property is null. TASK DETAIL https://phabricator.wikimedia.org/T310259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Pginer-WMF Cc: Pikne, Arian_Bozorg, ngkountas, Lucas_Werkmeister_WMDE, Hooman_Mallahzadeh, Nikerabbit, Snaevar, karapayneWMDE, ItamarWMDE, Tgr, EChukwukere-WMF, Lydia_Pintscher, santhosh, olga, Aklapper, Theklan, ovasileva, Pginer-WMF, JCW555, hnijhuis, Astuthiodit_1, Patafisik_WMF, Invadibot, Selby, Universal_Omega, maantietaja, Akuckartz, Demian, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Amire80, Arrbee, KartikMistry, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
