Pginer-WMF created this task. Pginer-WMF added projects: UniversalLanguageSelector, Wikidata.
TASK DESCRIPTION As a follow-up from T310259 <https://phabricator.wikimedia.org/T310259> where the option to "edit interlanguage links" was added to the language selector, this ticket is focused on making such option also available from the language selector empty state (T290436 <https://phabricator.wikimedia.org/T290436>). When pages are not available in other languages, the language selector shows an empty state to communicate that the user cannot navigate to other languages and lists the actions available. For example. looking at unconnected pages <https://en.wikipedia.org/wiki/Special:UnconnectedPages>, a page like Octomedusa <https://en.wikipedia.org/wiki/Octomedusa> is not listing the "edit interlanguage links". Proposal ======== The expected result is to have the "Edit language links" option listed, which should allow to connect equivalent pages in different languages. It can use the same process used in Vector legacy <https://en.wikipedia.org/wiki/Octomedusa?useskin=vector> | Current | Expected | | ------- | -------- | | F36824301: en.wikipedia.org_wiki_Octomedusa(iPad Air).png <https://phabricator.wikimedia.org/F36824301> | F34648628: nolangs-options.png <https://phabricator.wikimedia.org/F34648628> | | Technical details ================= Nik provided some details about the integration: In T310259#8589199 <https://phabricator.wikimedia.org/T310259#8589199>, @ngkountas wrote: > Adding to Pau's comment above, I checked that the module that registers the “Edit language links” action button is the `wikibase.client.vector-2022` module. I checked the loaded modules for the above page <https://en.wikipedia.org/wiki/Anniversary_Peak> (using `mw.inspect()` inside the Developer’s console) and the module doesn’t seem loaded. This is why the button is not visible. I checked the conditions used to add the module, in the codebase <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/client/includes/Hooks/BeforePageDisplayHandler.php#83> and I believe it's the following condition that prevents the module from being added: > > $outputPage->getProperty( 'wikibase_item' ) !== null > > The `wikibase_item` property for this page seems to be undefined. We can easily verify that by using the following API URL: https://en.wikipedia.org/w/api.php?action=query&prop=pageprops&titles=Anniversary_Peak&format=json and check that there is no "wikibase_item" key returned. > > So, I think we should also add the `wikibase.client.vector-2022` module for pages where `wikibase_item` property is null. TASK DETAIL https://phabricator.wikimedia.org/T329570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pginer-WMF Cc: santhosh, olga, Aklapper, Theklan, ovasileva, Pginer-WMF, ngkountas, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, Amire80, Nikerabbit, Arrbee, KartikMistry, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
