Jdlrobson moved this task from Code Review to Needs More Work on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4) board. Jdlrobson added a comment.
@alexhollender_WMF (and other's listening who have opinions) I want to play devils advocate here since this is not proving as trivial as first expected. If we want to keep iterating on this fine, but I am curious about what the long term solution is here. If we are expecting the language button to indefinitely appear in the sidebar, I'd rather spend time with the Wikidata developers working on a proper fix and removing our workarounds. As I understand it, the existing code was meant to be a temporary workaround while the language team incorporated the feature in the language selector (that's what the code documentation says <https://github.com/wikimedia/mediawiki-skins-Vector/blob/master/resources/skins.vector.js/languageButton.js#L4>). The language team already incorporated this feature into the language button for pages with language. F36875299: Screen Shot 2023-02-27 at 4.57.08 PM.png <https://phabricator.wikimedia.org/F36875299> F36875301: Screen Shot 2023-02-27 at 4.57.45 PM.png <https://phabricator.wikimedia.org/F36875301> although they still need to incorporate it for pages with no languages: {F36875305} Despite this, for some reason we still have this duplicate link and we're trying to add an icon to a menu that doesn't currently support icons on a solution that is already a workaround (e.g. we're adding workarounds to our existing workarounds). This is adding technical debt and IMO a weird inconsistency with other menu items that we'll have to revisit at some later date. The edit icon is also a little confusing as it suggests that you are going to open the editor, which is not what happens - an overlay is opened. (FWIW Jan's current patch iteration looks like this): F36875293: Screen Shot 2023-02-27 at 4.53.03 PM.png <https://phabricator.wikimedia.org/F36875293> Do we have any plans to address the fact the link spills out onto 2 lines as part of this task? This seems more of a concern to me right now. TASK DETAIL https://phabricator.wikimedia.org/T328069 WORKBOARD https://phabricator.wikimedia.org/project/board/6380/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Jdlrobson Cc: TheresNoTime, Patriccck, Urbanecm, jhsoby, GMikesell-WMF, Nux, Amire80, Zapipedia-WMF, Patafisik, RolandUnger, Iniquity, Raymond, ovasileva, alexhollender_WMF, Lucas_Werkmeister_WMDE, ItamarWMDE, Jdrewniak, Terasail, Aklapper, Jdlrobson, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Nishu02, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
