Sarai-WMDE added a comment.
Hello there! Just took a look at the LanguageSelector in Query builder and, first, it looks great! 💯 I just found a couple of small fixes: 1. The clear icon is not vertically aligned within the input: F36925363: Screenshot 2023-03-24 at 10.12 1.png <https://phabricator.wikimedia.org/F36925363> 2. If possible, the top border of the menu shouldn't be visible. It should overlap with the input's border. At the same time, the input drops a shadow on top of the menu with the value `0 1px 2px rgba( 0 , 0 , 0 , 0.251 )`. We should try this, as it would make the component look closer to the Style guide specs and the Language team's implementation. Nevertheless, if this is not an easy change, it's fine if we keep the current look as a compromise but make the top border radius 0px (the design direction here is a bit unclear for now, but the latter is what Codex does for now). F36925394: Screenshot 2023-03-24 at 11.27.50.png <https://phabricator.wikimedia.org/F36925394> TASK DETAIL https://phabricator.wikimedia.org/T328764 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lydia_Pintscher, guergana.tzatchkova, Lucas_Werkmeister_WMDE, ItamarWMDE, Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
