Lucas_Werkmeister_WMDE added a comment.
In T333454#8738592 <https://phabricator.wikimedia.org/T333454#8738592>, @Lucas_Werkmeister_WMDE wrote: > Do we need to add all composer packages that are used in Wikibase directly to Wikibase’s `composer.json`, instead of relying on MediaWiki core’s `composer.json` to install some of the dependencies? Nope, doesn’t work. phpstan prints the following message (without a trailing newline, grmbl): > Could not find composer.lock file. Have you run "composer install --no-dev"? `strace` reveals it’s looking for `composer.lock` in the MediaWiki core parent directory and its `vendor/` subdirectory, where no composer lockfile exists because we never ran `composer install` there. I feel like there’s a general mismatch here, between one side in CI which expects to be able to run `composer test` on an extension’s own Git repository without a broader MediaWiki setup, and between the other side in Wikibase which expects MediaWiki and its dependencies to have been installed when PHPStan runs. And I’m not sure how this can be reconciled… I thought there might be an alternative composer script that we could move the `phpstan` command into (instead of `composer test`), but I can’t see one in this CI output <https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-noselenium-docker/34789/consoleFull> (from this REL1_40 OAuth change <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/904068>) at least. TASK DETAIL https://phabricator.wikimedia.org/T333454 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
