Lucas_Werkmeister_WMDE added a comment.
Oh, and apparently it’s not even possible to have leading or trailing whitespace in an EntitySchema test? In my testing, edits that only add leading or trailing spaces or newlines become null edits (no new revision in the history), and with edits that change both surrounding whitespace and other content, only the non-whitespace changes survive. We must be trimming the schema text ourselves somewhere. I think that rules out option 4, and also means the impact of this task is limited to the browser tests, and we don’t need to e.g. ask product if it’s a problem that users don’t see any leading whitespace (because it’s not possible to have leading whitespace in the first place). TASK DETAIL https://phabricator.wikimedia.org/T334575 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lemondoge, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Dinoguy1000, jayvdb, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
