Daimona added a comment.
In T65632#8945234 <https://phabricator.wikimedia.org/T65632#8945234>, @matej_suchanek wrote: > I suspect MediawikiEditFilterHookRunner::getContextForEditFilter <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/41b35ffd4b9d060916c950cb3ad6600e516a0f72/repo/includes/EditEntity/MediawikiEditFilterHookRunner.php#120> does not carry over the "original" WikiPage instance (used as the "carrier" of the PreparedUpdate). This seems correct: instantiating a DerivativeContext does not set the `wikipage` field, which is lazy-loaded in `getWikipage()`, and created from scratch if a Title is available. I'd be a bit scared changing this in any way though (e.g., persisting the WikiPage object), because of the potential side effects it could have. OTOH, I don't think there's a task for adding PreparedUpdate to the hook parameters. Should we just do that instead? I think that would mean creating a new hook; it might be a good occasion to address some of the issues reported in T304238 <https://phabricator.wikimedia.org/T304238>. TASK DETAIL https://phabricator.wikimedia.org/T65632 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Daimona, matej_suchanek, Lydia_Pintscher, daniel, hoo, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 94rain, Dinadineke, Nandana, lucamauri, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, ihojose, JakeTheDeveloper, QZanden, merbst, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, TheDJ, Jackmcbarn, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
