Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikimedia-production-error, Wikidata, Wikidata Lexicographical data, wdwb-tech.
TASK DESCRIPTION Error ----- - mwversion: 1.41.0-wmf.13 - reqId: 996a57dc-48a5-4fbf-9ef9-d1590828a82b - Find reqId in Logstash <https://logstash.wikimedia.org/app/dashboards#/view/AXFV7JE83bOlOASGccsT?_g=(time:(from:'2023-06-19T09:29:25.830Z',to:'2023-06-20T10:22:19.844Z'))&_a=(query:(query_string:(query:'reqId:%22996a57dc-48a5-4fbf-9ef9-d1590828a82b%22')))> name=normalized_message [{reqId}] {exception_url} Error: Call to undefined method Wikibase\DataModel\Entity\Item::getRepresentations() name=exception.trace from /srv/mediawiki/php-1.41.0-wmf.13/extensions/WikibaseLexeme/src/Presentation/Formatters/FormIdTextFormatter.php(57) #0 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/lib/includes/Formatters/EntityIdValueFormatter.php(44): Wikibase\Lexeme\Presentation\Formatters\FormIdTextFormatter->formatEntityId(Wikibase\DataModel\Entity\ItemId) #1 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/lib/includes/Formatters/DispatchingValueFormatter.php(72): Wikibase\Lib\Formatters\EntityIdValueFormatter->format(Wikibase\DataModel\Entity\EntityIdValue) #2 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/lib/includes/Formatters/PropertyValueSnakFormatter.php(148): Wikibase\Lib\Formatters\DispatchingValueFormatter->formatValue(Wikibase\DataModel\Entity\EntityIdValue, string) #3 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/lib/includes/Formatters/PropertyValueSnakFormatter.php(117): Wikibase\Lib\Formatters\PropertyValueSnakFormatter->formatValue(Wikibase\DataModel\Entity\EntityIdValue, string) #4 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/lib/includes/Formatters/DispatchingSnakFormatter.php(150): Wikibase\Lib\Formatters\PropertyValueSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak) #5 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/lib/includes/Formatters/ErrorHandlingSnakFormatter.php(68): Wikibase\Lib\Formatters\DispatchingSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak) #6 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/repo/includes/Api/FormatSnakValue.php(177): Wikibase\Lib\Formatters\ErrorHandlingSnakFormatter->formatSnak(Wikibase\DataModel\Snak\PropertyValueSnak) #7 /srv/mediawiki/php-1.41.0-wmf.13/extensions/Wikibase/repo/includes/Api/FormatSnakValue.php(145): Wikibase\Repo\Api\FormatSnakValue->formatValue(array, Wikibase\DataModel\Entity\EntityIdValue, NULL) #8 /srv/mediawiki/php-1.41.0-wmf.13/includes/api/ApiMain.php(1913): Wikibase\Repo\Api\FormatSnakValue->execute() #9 /srv/mediawiki/php-1.41.0-wmf.13/includes/api/ApiMain.php(890): ApiMain->executeAction() #10 /srv/mediawiki/php-1.41.0-wmf.13/includes/api/ApiMain.php(861): ApiMain->executeActionWithErrorHandling() #11 /srv/mediawiki/php-1.41.0-wmf.13/api.php(95): ApiMain->execute() #12 /srv/mediawiki/php-1.41.0-wmf.13/api.php(48): wfApiMain() #13 /srv/mediawiki/w/api.php(3): require(string) #14 {main} Impact ------ Minimal. An invalid request with no sensible interpretation can be used to trigger logspam. Only one actual occurrence in logstash. Notes ----- The decoded request URL is: - action: `wbformatvalue` - datavalue: `{"value":{"id":"Q96"},"type":"wikibase-entityid"}` - property: Wikidata property example for forms (P5193) <https://www.wikidata.org/wiki/Property:P5193> In other words, someone’s formatting an item ID value with a property that’s intended for form IDs, hence the type error. The formatter just needs to handle this a bit more carefully (producing a better error when the given value doesn’t look as expected). A similar exception was previously seen in CI: T201988: FormIdHtmlFormatter: Call to undefined method Item::getRepresentations() <https://phabricator.wikimedia.org/T201988> TASK DETAIL https://phabricator.wikimedia.org/T339904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
