Lucas_Werkmeister_WMDE added a comment.
Random tech notes from me:
- The current formatting (link with ID as text) happens in
`EntitySchemaFormatter`. We probably want to extend that class to add the label
formatting (or potentially split the HTML and plain text cases into separate
classes, but that might not be needed).
- We can probably implement the label lookup the same way we implement the
lookup in WikibaseLexeme: just load the whole EntitySchema data and get the
label from there. We don’t need to use a more efficient term store until
performance becomes too bad (which hasn’t even happened for lexemes yet – we’re
still using this inefficient strategy there, as far as I’m aware).
- But it should at least be in a separate service, not directly in the
formatter.
TASK DETAIL
https://phabricator.wikimedia.org/T338613
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Arian_Bozorg, Astuthiodit_1,
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana,
Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation,
LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian,
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
